Skip to content

Commit d5a7453

Browse files
committed
internal/lsp/source: disable fillstruct by default
The discussion on golang/vscode-go#299 has uncovered the fact that go/printer is very expensive, and we're calling it frequently on file changes. Analyzers whose suggested fixes require the original file content are generally posing issues; this is being discussed on golang/go#40110. Updates golang/vscode-go#299 Change-Id: I5cb370c9cb508203e463e7243fc781e75876fe30 Reviewed-on: https://go-review.googlesource.com/c/tools/+/241321 Run-TryBot: Rebecca Stambler <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
1 parent 065b96d commit d5a7453

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/lsp/source/options.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -659,7 +659,7 @@ func convenienceAnalyzers() map[string]Analyzer {
659659
return map[string]Analyzer{
660660
fillstruct.Analyzer.Name: {
661661
Analyzer: fillstruct.Analyzer,
662-
enabled: true,
662+
enabled: false,
663663
},
664664
}
665665
}

0 commit comments

Comments
 (0)