feat: improve error message on malformed struct #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I16db93c2f2bb0168487c2396b746fbb25caf6a72
cf39881 to
df95d79
Compare
mutianf
approved these changes
Jun 2, 2025
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
🤖 I have created a release *beep* *boop* --- ## [2.60.0](https://togithub.com/googleapis/java-bigtable/compare/v2.59.0...v2.60.0) (2025-06-06) ### Features * Improve error message on malformed struct ([#2592](https://togithub.com/googleapis/java-bigtable/issues/2592)) ([7f5fdf0](https://togithub.com/googleapis/java-bigtable/commit/7f5fdf094c5fe140807ce6abcea0b891462ba809)) * Run ExecuteQuery conformance tests ([#2557](https://togithub.com/googleapis/java-bigtable/issues/2557)) ([0bbc083](https://togithub.com/googleapis/java-bigtable/commit/0bbc083b9e798e5b557f3ffe7090b45e66c9ada5)) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.59.0 ([65782aa](https://togithub.com/googleapis/java-bigtable/commit/65782aaf89ad78aafd7f5928e81e513c3016b471)) * Ensure that multiple instances of a client in the same process dont clobber each other ([#2590](https://togithub.com/googleapis/java-bigtable/issues/2590)) ([8d3dca4](https://togithub.com/googleapis/java-bigtable/commit/8d3dca43224179829829bcf91972610c666b130b)) ### Dependencies * Update shared dependencies ([#2587](https://togithub.com/googleapis/java-bigtable/issues/2587)) ([8ec0339](https://togithub.com/googleapis/java-bigtable/commit/8ec033994f20b2b3aea0dfcdaffbdd1c6d19fdad)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly so that we have a stable error message to match on in the conformance tests, rather than relying on the format of the underlying index out of bounds if there is missing struct data. This message is also clearer for users if this were to ever happen
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.