Skip to content

test: fix logging tests #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 20, 2021
Merged

test: fix logging tests #493

merged 13 commits into from
Apr 20, 2021

Conversation

simonz130
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #426 ☕️

@simonz130 simonz130 added api: logging Issues related to the googleapis/java-logging API. automerge Merge the pull request once unit tests and other checks pass. labels Apr 13, 2021
@simonz130 simonz130 requested a review from daniel-sanche April 13, 2021 23:06
@simonz130 simonz130 self-assigned this Apr 13, 2021
@simonz130 simonz130 requested a review from a team as a code owner April 13, 2021 23:06
@simonz130 simonz130 requested a review from a team April 13, 2021 23:06
@simonz130 simonz130 requested a review from a team as a code owner April 13, 2021 23:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #493 (f12019c) into master (9b0423f) will increase coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #493      +/-   ##
============================================
+ Coverage     79.30%   79.32%   +0.01%     
  Complexity      745      745              
============================================
  Files            44       44              
  Lines          4253     4252       -1     
  Branches        287      286       -1     
============================================
  Hits           3373     3373              
  Misses          692      692              
+ Partials        188      187       -1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/logging/SinkInfo.java 80.69% <0.00%> (ø) 19.00 <0.00> (ø)
.../java/com/google/cloud/logging/LoggingHandler.java 74.31% <100.00%> (+0.67%) 22.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0423f...f12019c. Read the comment docs.

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2021
@simonz130 simonz130 changed the title Logging tests test: fix logging tests Apr 14, 2021
@simonz130 simonz130 merged commit 99c9653 into googleapis:master Apr 20, 2021
@simonz130 simonz130 deleted the loggingTests branch April 20, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent log ordering
2 participants