Skip to content

OpenTelemetrySpanTest.transactionRunner is flaky with multiplexed sessions #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
olavloite opened this issue Jun 10, 2024 · 0 comments · Fixed by #3153
Closed

OpenTelemetrySpanTest.transactionRunner is flaky with multiplexed sessions #3152

olavloite opened this issue Jun 10, 2024 · 0 comments · Fixed by #3153
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: cleanup An internal cleanup or hygiene concern.

Comments

@olavloite
Copy link
Collaborator

olavloite commented Jun 10, 2024 •
edited
Loading 

Error:  Failures: 
Error:    OpenTelemetrySpanTest.transactionRunner:495->verifySpans:825 expected:<
[CloudSpanner.ReadWriteTransaction, CloudSpannerOperation.BatchCreateSessions, CloudSpannerOperation.BatchCreateSessionsRequest, CloudSpannerOperation.Commit, CloudSpannerOperation.CreateMultiplexedSession, CloudSpannerOperation.ExecuteUpdate]
> but was:<
[CloudSpanner.ReadWriteTransaction, CloudSpannerOperation.BatchCreateSessionsRequest, CloudSpannerOperation.Commit, CloudSpannerOperation.CreateMultiplexedSession, CloudSpannerOperation.ExecuteUpdate]>
@olavloite olavloite self-assigned this Jun 10, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jun 10, 2024
@olavloite olavloite added type: cleanup An internal cleanup or hygiene concern. and removed api: spanner Issues related to the googleapis/java-spanner API. labels Jun 10, 2024
olavloite added a commit that referenced this issue Jun 10, 2024
@olavloite
chore: add wait for async span
a948337 
Add a wait for the BatchCreateSessions span, as that operation
is executed asynchronously, and is not guaranteed to have finished
when the transaction finishes. The reason for this is that the
transaction only needs 1 session, while the operation creates 4
sessions, and the operation only finishes once all 4 sessions
have been created.

Fixes #3152
@olavloite olavloite mentioned this issue Jun 10, 2024
Merged
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add wait for async span googleapis/java-spanner
1 participant
@olavloite