Skip to content

chore(cleanup): address review comments for spangres parser #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2022
Merged

chore(cleanup): address review comments for spangres parser #1752

merged 1 commit into from
Mar 16, 2022

Conversation

olavloite
Copy link
Collaborator

Addresses additional review comments in #1737

@ansh0l PTAL

@olavloite olavloite requested a review from ansh0l March 16, 2022 06:05
@olavloite olavloite requested review from a team as code owners March 16, 2022 06:05
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 16, 2022
ansh0l
ansh0l approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite merged commit a008790 into main Mar 16, 2022
@olavloite olavloite deleted the spangres-parser-review-comments branch March 16, 2022 07:18
gcf-owl-bot bot added a commit that referenced this pull request Jan 19, 2023
@gcf-owl-bot @dependabot
build(deps): bump protobuf from 3.20.1 to 3.20.2 in /synthtool/gcp/te…
f332109 
…mplates/java_library/.kokoro (#1752)

build(deps): bump protobuf

Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 3.20.1 to 3.20.2.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v3.20.1...v3.20.2)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@239f962
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d5da32501662e4e53365220cc14cfb1d3b9446585397d57dac50171d92556ae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh0l ansh0l ansh0l approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olavloite @ansh0l