Skip to content

chore: wait for all spans to finish to fix flakiness in test #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

chore: wait for all spans to finish to fix flakiness in test #3087

merged 1 commit into from
May 3, 2024

Conversation

olavloite
Copy link
Collaborator

Fixes #3084

@olavloite olavloite requested a review from a team as a code owner May 3, 2024 08:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels May 3, 2024
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit c64c8f8 into main May 3, 2024
30 of 34 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the issue-3084 branch May 3, 2024 08:56
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenTelemetrySpanTest.transactionRunnerWithFailedAndBeginTransaction is flaky
3 participants
@olavloite @surbhigarg92 @rahul2393