chore: Composite Tracer #3163
Merged
chore: Composite Tracer #3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
approved these changes
Jun 18, 2024
google-cloud-spanner/src/main/java/com/google/cloud/spanner/CompositeTracer.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/CompositeTracer.java
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| public void addAttributes(String key, String value) { |
There was a problem hiding this comment.
Where/when is this method called? It does not override any methods (at least it is not marked as such), and I can't find anything in this PR that seems to call it.
There was a problem hiding this comment.
This will be required for MetricsTracer
Added in advance
e00b884
into
googleapis:main
31 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.