-
Notifications
You must be signed in to change notification settings - Fork 132
test: close Spanner instance after test #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
=========================================
Coverage 85.17% 85.17%
- Complexity 2619 2621 +2
=========================================
Files 145 145
Lines 14262 14262
Branches 1378 1378
=========================================
+ Hits 12147 12148 +1
+ Misses 1540 1538 -2
- Partials 575 576 +1
Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Feb 23, 2021
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#6666 Changes: chore(security/publicca): Configure Ruby client for PublicCA V1beta1 PiperOrigin-RevId: 474084761 Source-Link: googleapis/googleapis@2d8030c docs(vision/v2): update comments for image annotator OCR models PiperOrigin-RevId: 474070246 Source-Link: googleapis/googleapis@346e2f2 chore: regenerate API index Source-Link: googleapis/googleapis@a217609 feat: Publish CBT deletion_protection field in Table, UpdateTableRequest, and UpdateTable API in **stable** proto to external customers PiperOrigin-RevId: 474010093 Source-Link: googleapis/googleapis@e210283 chore: regenerate API index Source-Link: googleapis/googleapis@450fbd0 fix(spanner/admin/database)!: Revert add custom instance config operations (change broke client libraries; reverting before any are released) PiperOrigin-RevId: 473985182 Source-Link: googleapis/googleapis@e544df5 chore: regenerate API index Source-Link: googleapis/googleapis@e2bb76c feat(spanner/admin/database): Add custom instance config operations PiperOrigin-RevId: 473928081 Source-Link: googleapis/googleapis@5440048 fix(bigquery/connection): integrate gapic-generator-python-1.4.1 and enable more py_test targets PiperOrigin-RevId: 473833416 Source-Link: googleapis/googleapis@565a550 chore: regenerate API index Source-Link: googleapis/googleapis@9d1fbd0 feat(bigquery/storage): add proto annotation for non-ascii field mapping PiperOrigin-RevId: 473815595 Source-Link: googleapis/googleapis@46cfc4c fix: Fix resource name configuration for graph API PiperOrigin-RevId: 473812596 Source-Link: googleapis/googleapis@0cac79b fix: Fix resource name for remoteworkers API PiperOrigin-RevId: 473797330 Source-Link: googleapis/googleapis@18cb30d fix(recommendationengine): Fix recommendationengine resource name configuration PiperOrigin-RevId: 473779245 Source-Link: googleapis/googleapis@ee05df9 chore: regenerate API index Source-Link: googleapis/googleapis@2c489b4 feat: generate BigQuery Analytics Hub API v1 client with renamed package name PiperOrigin-RevId: 473765630 Source-Link: googleapis/googleapis@76c3b84 chore: regenerate API index Source-Link: googleapis/googleapis@4c6e7ec feat(firestore/apiv1): add firestore aggregation query apis to the stable googleapis branch PiperOrigin-RevId: 473753776 Source-Link: googleapis/googleapis@a8c6c7c feat: published Cloud IDS Service v1 Logging PiperOrigin-RevId: 473541339 Source-Link: googleapis/googleapis@b174c58 fix: remove 'cloud' name from package names PiperOrigin-RevId: 473353883 Source-Link: googleapis/googleapis@8167bad chore: regenerate API index Source-Link: googleapis/googleapis@3a55875 feat(storagetransfer): add default retry configuration feat: add DeleteTransferJob operation feat: add AWS S3 compatible data source PiperOrigin-RevId: 473348271 Source-Link: googleapis/googleapis@56f2049 chore(mediatranslation): revert enable REST transport support for python media-translation PiperOrigin-RevId: 473280851 Source-Link: googleapis/googleapis@38e8b44 chore: regenerate API index Source-Link: googleapis/googleapis@49dd298 feat: add Address Validation API PiperOrigin-RevId: 473247330 Source-Link: googleapis/googleapis@7b2540a feat(analytics/admin): Enable REST transport support for Python analytics-admin, media-translation and dataflow clients PiperOrigin-RevId: 473076638 Source-Link: googleapis/googleapis@f0e2be4
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/java-spanner API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SpannerGapicRpcTest.testCustomUserAgent
test opened a newSpanner
instance that was not closed after the test had finished. This would cause the threads that were used by that instance to remain active until the entire test run had finished. If this test happened to be executed before one of the tests that verify that all threads are closed when aSpanner
instance is closed, the test would fail as it would detect the threads that were still active from the other test case.Fixes #889