Skip to content

test: close Spanner instance after test #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2021
Merged

test: close Spanner instance after test #894

merged 1 commit into from
Feb 23, 2021

Conversation

olavloite
Copy link
Collaborator

The SpannerGapicRpcTest.testCustomUserAgent test opened a new Spanner instance that was not closed after the test had finished. This would cause the threads that were used by that instance to remain active until the entire test run had finished. If this test happened to be executed before one of the tests that verify that all threads are closed when a Spanner instance is closed, the test would fail as it would detect the threads that were still active from the other test case.

Fixes #889

@olavloite olavloite requested a review from a team as a code owner February 19, 2021 08:18
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Feb 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #894 (df306b3) into master (b2b7bb2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #894   +/-   ##
=========================================
  Coverage     85.17%   85.17%           
- Complexity     2619     2621    +2     
=========================================
  Files           145      145           
  Lines         14262    14262           
  Branches       1378     1378           
=========================================
+ Hits          12147    12148    +1     
+ Misses         1540     1538    -2     
- Partials        575      576    +1     
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/spanner/SessionPool.java 89.03% <0.00%> (ø) 72.00% <0.00%> (ø%)
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (ø) 18.00% <0.00%> (+1.00%)
.../google/cloud/spanner/AbstractLazyInitializer.java 100.00% <0.00%> (+7.14%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b7bb2...b78509f. Read the comment docs.

@thiagotnunes thiagotnunes merged commit b08f095 into master Feb 23, 2021
@thiagotnunes thiagotnunes deleted the issue-889 branch February 23, 2021 01:22
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#6666

Changes:

chore(security/publicca): Configure Ruby client for PublicCA V1beta1
  PiperOrigin-RevId: 474084761
  Source-Link: googleapis/googleapis@2d8030c

docs(vision/v2): update comments for image annotator OCR models
  PiperOrigin-RevId: 474070246
  Source-Link: googleapis/googleapis@346e2f2

chore: regenerate API index

  Source-Link: googleapis/googleapis@a217609

feat: Publish CBT deletion_protection field in Table, UpdateTableRequest, and UpdateTable API in **stable** proto to external customers
  PiperOrigin-RevId: 474010093
  Source-Link: googleapis/googleapis@e210283

chore: regenerate API index

  Source-Link: googleapis/googleapis@450fbd0

fix(spanner/admin/database)!: Revert add custom instance config operations (change broke client libraries; reverting before any are released)
  PiperOrigin-RevId: 473985182
  Source-Link: googleapis/googleapis@e544df5

chore: regenerate API index

  Source-Link: googleapis/googleapis@e2bb76c

feat(spanner/admin/database): Add custom instance config operations
  PiperOrigin-RevId: 473928081
  Source-Link: googleapis/googleapis@5440048

fix(bigquery/connection): integrate  gapic-generator-python-1.4.1 and enable more py_test targets
  PiperOrigin-RevId: 473833416
  Source-Link: googleapis/googleapis@565a550

chore: regenerate API index

  Source-Link: googleapis/googleapis@9d1fbd0

feat(bigquery/storage): add proto annotation for non-ascii field mapping
  PiperOrigin-RevId: 473815595
  Source-Link: googleapis/googleapis@46cfc4c

fix: Fix resource name configuration for graph API
  PiperOrigin-RevId: 473812596
  Source-Link: googleapis/googleapis@0cac79b

fix: Fix resource name for remoteworkers API
  PiperOrigin-RevId: 473797330
  Source-Link: googleapis/googleapis@18cb30d

fix(recommendationengine): Fix recommendationengine resource name configuration
  PiperOrigin-RevId: 473779245
  Source-Link: googleapis/googleapis@ee05df9

chore: regenerate API index

  Source-Link: googleapis/googleapis@2c489b4

feat: generate BigQuery Analytics Hub API v1 client with renamed package name
  PiperOrigin-RevId: 473765630
  Source-Link: googleapis/googleapis@76c3b84

chore: regenerate API index

  Source-Link: googleapis/googleapis@4c6e7ec

feat(firestore/apiv1): add firestore aggregation query apis to the stable googleapis branch
  PiperOrigin-RevId: 473753776
  Source-Link: googleapis/googleapis@a8c6c7c

feat: published Cloud IDS Service v1 Logging
  PiperOrigin-RevId: 473541339
  Source-Link: googleapis/googleapis@b174c58

fix: remove 'cloud' name from package names
  PiperOrigin-RevId: 473353883
  Source-Link: googleapis/googleapis@8167bad

chore: regenerate API index

  Source-Link: googleapis/googleapis@3a55875

feat(storagetransfer): add default retry configuration feat: add DeleteTransferJob operation feat: add AWS S3 compatible data source
  PiperOrigin-RevId: 473348271
  Source-Link: googleapis/googleapis@56f2049

chore(mediatranslation): revert enable REST transport support for python media-translation
  PiperOrigin-RevId: 473280851
  Source-Link: googleapis/googleapis@38e8b44

chore: regenerate API index

  Source-Link: googleapis/googleapis@49dd298

feat: add Address Validation API
  PiperOrigin-RevId: 473247330
  Source-Link: googleapis/googleapis@7b2540a

feat(analytics/admin): Enable REST transport support for Python analytics-admin, media-translation and dataflow clients
  PiperOrigin-RevId: 473076638
  Source-Link: googleapis/googleapis@f0e2be4
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky GapicSpannerRpcTest
2 participants