Skip to content

test: fail if the same token is seen twice #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

olavloite
Copy link
Collaborator

The backup pagination test should fail if the same page token is returned twice by the backend, instead of fetching the same page indefinitely. Further investigation is necessary if that actually happens, as it is not something that is expected.

@olavloite olavloite requested a review from thiagotnunes March 17, 2021 10:55
@olavloite olavloite requested a review from a team as a code owner March 17, 2021 10:55
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2021
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #983 (c1add12) into master (fc305b7) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #983      +/-   ##
============================================
- Coverage     85.11%   85.09%   -0.02%     
+ Complexity     2619     2616       -3     
============================================
  Files           154      154              
  Lines         14319    14319              
  Branches       1331     1331              
============================================
- Hits          12187    12185       -2     
- Misses         1567     1570       +3     
+ Partials        565      564       -1     
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/spanner/SessionPool.java 89.12% <0.00%> (-0.20%) 72.00% <0.00%> (-1.00%)
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (ø) 17.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc305b7...c1add12. Read the comment docs.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 459a477 into master Mar 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fail-on-same-token branch March 18, 2021 08:14
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 18, 2021
thiagotnunes pushed a commit that referenced this pull request Mar 19, 2021
The backup pagination test should fail if the same page token is returned twice by the backend, instead of fetching the same page indefinitely. Further investigation is necessary if that actually happens, as it is not something that is expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants