Skip to content

Commit 1737adc

Browse files
authored
feat: remove support for Python 3.8 (#216)
1 parent 94f69ea commit 1737adc

6 files changed

+13
-16
lines changed

.github/sync-repo-settings.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ branchProtectionRules:
2727
requiredStatusCheckContexts:
2828
- "cla/google"
2929
- "lint"
30-
- "pg-integration-test-pr-py38 (langchain-cloud-sql-testing)"
3130
- "pg-integration-test-pr-py39 (langchain-cloud-sql-testing)"
3231
- "pg-integration-test-pr-py310 (langchain-cloud-sql-testing)"
3332
- "pg-integration-test-pr-py311 (langchain-cloud-sql-testing)"

DEVELOPER.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Learn more by reading [How should I write my commits?](https://github.com/google
2828

2929
Notes:
3030

31-
* Tests use both IAM and built-in authentication.
31+
* Tests use both IAM and built-in authentication.
3232
* Learn how to set up a built-in databases user at [Cloud SQL built-in database authentication](https://cloud.google.com/sql/docs/postgres/built-in-authentication).
3333
* Local tests will run against your `gcloud` credentials. Use `gcloud` to login with your personal account or a service account. This account will be used to run IAM tests. Learn how to set up access to the database at [Manage users with IAM database authentication](https://cloud.google.com/sql/docs/postgres/add-manage-iam-users). The "IAM_ACCOUNT" environment variable is also used to test authentication to override the local account. A personal account or a service account can be used for this test.
3434
* You may need to grant access to the public schema for your new database user: `GRANT ALL ON SCHEMA public TO [email protected];`
@@ -42,11 +42,11 @@ These tests are registered as required tests in `.github/sync-repo-settings.yaml
4242

4343
#### Trigger Setup
4444

45-
Cloud Build triggers (for Python versions 3.8 to 3.11) were created with the following specs:
45+
Cloud Build triggers (for Python versions 3.9 to 3.11) were created with the following specs:
4646

4747
```YAML
48-
name: pg-integration-test-pr-py38
49-
description: Run integration tests on PR for Python 3.8
48+
name: pg-integration-test-pr-py39
49+
description: Run integration tests on PR for Python 3.9
5050
filename: integration.cloudbuild.yaml
5151
github:
5252
name: langchain-google-cloud-sql-pg-python
@@ -64,7 +64,7 @@ substitutions:
6464
_DATABASE_ID: <ADD_VALUE>
6565
_INSTANCE_ID: <ADD_VALUE>
6666
_REGION: us-central1
67-
_VERSION: "3.8"
67+
_VERSION: "3.9"
6868
```
6969

7070
Use `gcloud builds triggers import --source=trigger.yaml` to create triggers via the command line
@@ -89,7 +89,7 @@ To run Cloud Build tests on GitHub from external contributors, ie RenovateBot, c
8989
#### Code Coverage
9090
Please make sure your code is fully tested. The Cloud Build integration tests are run with the `pytest-cov` code coverage plugin. They fail for PRs with a code coverage less than the threshold specified in `.coveragerc`. If your file is inside the main module and should be ignored by code coverage check, add it to the `omit` section of `.coveragerc`.
9191

92-
Check for code coverage report in any Cloud Build integration test log.
92+
Check for code coverage report in any Cloud Build integration test log.
9393
Here is a breakdown of the report:
9494
- `Stmts`: lines of executable code (statements).
9595
- `Miss`: number of lines not covered by tests.

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ dependencies.
4848
Supported Python Versions
4949
^^^^^^^^^^^^^^^^^^^^^^^^^
5050

51-
Python >= 3.8
51+
Python >= 3.9
5252

5353
Mac/Linux
5454
^^^^^^^^^

integration.cloudbuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ substitutions:
6262
_DATABASE_PORT: "5432"
6363
_DATABASE_ID: test-database
6464
_REGION: us-central1
65-
_VERSION: "3.8"
65+
_VERSION: "3.9"
6666
_IP_ADDRESS: "127.0.0.1"
6767

6868
options:

pyproject.toml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ dynamic = ["version"]
44
description = "LangChain integrations for Google Cloud SQL for PostgreSQL"
55
readme = "README.rst"
66
license = {file = "LICENSE"}
7-
requires-python = ">=3.8"
7+
requires-python = ">=3.9"
88
authors = [
99
{name = "Google LLC", email = "[email protected]"}
1010
]
@@ -22,7 +22,6 @@ classifiers = [
2222
"License :: OSI Approved :: Apache Software License",
2323
"Programming Language :: Python",
2424
"Programming Language :: Python :: 3",
25-
"Programming Language :: Python :: 3.8",
2625
"Programming Language :: Python :: 3.9",
2726
"Programming Language :: Python :: 3.10",
2827
"Programming Language :: Python :: 3.11",
@@ -53,13 +52,13 @@ requires = ["setuptools"]
5352
build-backend = "setuptools.build_meta"
5453

5554
[tool.black]
56-
target-version = ['py38']
55+
target-version = ['py39']
5756

5857
[tool.isort]
5958
profile = "black"
6059

6160
[tool.mypy]
62-
python_version = 3.8
61+
python_version = 3.9
6362
warn_unused_configs = true
6463
disallow_incomplete_defs = true
6564

requirements.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
cloud-sql-python-connector[asyncpg]==1.12.0
2-
langchain-core==0.2.38
3-
numpy==1.24.4; python_version<='3.8'
4-
numpy==1.26.4; python_version>'3.8'
2+
langchain-core==0.3.0
3+
numpy==1.26.4
54
pgvector==0.3.2
65
SQLAlchemy[asyncio]==2.0.34

0 commit comments

Comments
 (0)