Skip to content

feat: change query parameter to query_or_table in read_gbq #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested review from a team as code owners October 20, 2023 17:25
@ashleyxuu ashleyxuu requested a review from Genesis929 October 20, 2023 17:25
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 20, 2023
@ashleyxuu ashleyxuu requested a review from shobsi October 20, 2023 17:26
@ashleyxuu ashleyxuu force-pushed the ashleyxu-change-read_gbq_params branch from 3d48e84 to 8213970 Compare October 20, 2023 17:52
@tswast tswast changed the title feat: change param name in read_gbq feat: change query parameter to query_or_table in read_gbq Oct 20, 2023
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 20, 2023
@tswast
Copy link
Collaborator

tswast commented Oct 20, 2023

Quick feedback: The commit subject doesn't communicate everything the user needs to know. I update the PR title, but ideally the commit message would reflect this too.

@gcf-merge-on-green gcf-merge-on-green bot merged commit f9bb3c4 into main Oct 20, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the ashleyxu-change-read_gbq_params branch October 20, 2023 20:48
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants