Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Oct 30, 2025

Towards the code sample in #2200 🦕

@tswast tswast requested review from a team as code owners October 30, 2025 18:43
@tswast tswast requested a review from GarrettWu October 30, 2025 18:43
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 30, 2025
@tswast tswast requested review from jialuoo and removed request for GarrettWu October 30, 2025 19:11
@tswast
Copy link
Collaborator Author

tswast commented Oct 30, 2025

@jialuoo could you take a look? #2200 was also assigned to you, but I think it's important to do this one first.

Raises:
NotImplementedError:
GeoSeries.area is not supported. Use bigframes.bigquery.st_area(series), instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it 'st_simplify' here instead of 'st_area'?

`NotImplementedError` with a helpful message.
`NotImplementedError` with a helpful message. Likewise, if a
required parameter takes a value in terms of the coordinate
system, but BigQuery uses meters, rais a `NotImplementedError`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here: 'rais'

@tswast tswast requested a review from jialuoo October 31, 2025 16:12
@tswast
Copy link
Collaborator Author

tswast commented Oct 31, 2025

doctest failure is FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate likely a flake.

@tswast tswast merged commit ecee2bc into main Oct 31, 2025
19 of 25 checks passed
@tswast tswast deleted the feat-st-simplify branch October 31, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants