fix: Fix bug converting non-string labels to sql ids #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shobsi
reviewed
Jan 3, 2024
| return col_ids, idx_ids | ||
|
|
||
|
|
||
| def label_to_identifier(label: typing.Hashable, strict: bool = False) -> str: |
There was a problem hiding this comment.
would be nice to have unit tests on these utils methods
There was a problem hiding this comment.
Since utils are not part of the public API, I would prefer to test them via the public APIs that use them. I tried to include some unusual labels in the test cases.
There was a problem hiding this comment.
Sounds good, let's add these two kinds of labels to test the strict mode:
- Leading spaces followed by alpha-numeric
- Leading spaces followed by
_
shobsi
approved these changes
Jan 4, 2024
| return col_ids, idx_ids | ||
|
|
||
|
|
||
| def label_to_identifier(label: typing.Hashable, strict: bool = False) -> str: |
There was a problem hiding this comment.
Sounds good, let's add these two kinds of labels to test the strict mode:
- Leading spaces followed by alpha-numeric
- Leading spaces followed by
_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕