feat: add ml.metrics.pairwise.cosine_similarity function #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleyxuu
reviewed
Feb 12, 2024
| Input data. X and Y are mapped by indexes, must have the same index. | ||
|
|
||
| Returns: | ||
| DataFrame with columns of X, Y and cosine_similarity |
There was a problem hiding this comment.
Add the type hint as well: bigframes.dataframe.DataFrame: DataFrame with columns of X, Y and cosine_similarity
| @@ -84,6 +62,59 @@ def _apply_sql( | |||
|
|
|||
| return df | |||
|
|
|||
| def distance( | |||
There was a problem hiding this comment.
Can we add docstring here too?
| import bigframes.pandas as bpd | ||
|
|
||
|
|
||
| def test_cosine_similarity(): |
There was a problem hiding this comment.
I assume this ML.DISTANCE COSINE in BQML is different from sklearn package sklearn.metrics.pairwise import cosine_similarity, are these two comparable?
from sklearn.metrics.pairwise import cosine_similarity
X = [[4.1, 0.5, 1.0]]
Y = [[3.0, 0, 2.5]]
cosine_similarity(X, Y)
There was a problem hiding this comment.
Totally different, sklearn takes matrixes and returns matrixes, which we will be hard to support.
ashleyxuu
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕