Skip to content

fix: avoid ibis warning for "database" table() method argument #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Feb 23, 2024

This may be related to sqlglot parsing errors reported in #315.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #315 🦕

@tswast tswast requested review from a team as code owners February 23, 2024 18:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 23, 2024
@tswast tswast requested review from shobsi and removed request for stevewalker-de February 23, 2024 18:59
@tswast tswast merged commit a0490a4 into main Feb 26, 2024
@tswast tswast deleted the issue315-ibis-schema-warning branch February 26, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlglot.errors.ParseError for sample from website
2 participants