Skip to content

fix: assign NaN scalar to column error. #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 29, 2024
Merged

fix: assign NaN scalar to column error. #513

merged 5 commits into from
Mar 29, 2024

Conversation

Genesis929
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 25, 2024
@Genesis929 Genesis929 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2024
@Genesis929 Genesis929 marked this pull request as ready for review March 25, 2024 22:58
@Genesis929 Genesis929 requested review from a team as code owners March 25, 2024 22:58
@Genesis929 Genesis929 requested review from GarrettWu and tswast March 25, 2024 22:58
GarrettWu
GarrettWu approved these changes Mar 28, 2024
View reviewed changes
tests/system/small/test_dataframe.py Outdated
("scalar",),
[
(2.1,),
(np.nan,),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be np.nan? Or None is just fine, then you don't need to import numpy.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@tswast tswast merged commit 0a4153c into main Mar 29, 2024
16 checks passed
@tswast tswast deleted the scalar-set-huanc branch March 29, 2024 21:07
@release-please release-please bot mentioned this pull request Mar 29, 2024
Merged
Genesis929 added a commit that referenced this pull request Apr 9, 2024
@Genesis929
fix: assign NaN scalar to column error. (#513)
56e226f 
* fix: assign NaN scalar to column error.

* Update test.

* remove import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Genesis929 @tswast @GarrettWu