Skip to content

docs: Mark Gemini model as Pre-GA #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2024
Merged

docs: Mark Gemini model as Pre-GA #543

merged 2 commits into from
Mar 29, 2024

Conversation

GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested review from shobsi and ashleyxuu March 28, 2024 23:24
@GarrettWu GarrettWu requested review from a team as code owners March 28, 2024 23:24
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 28, 2024
@GarrettWu GarrettWu added automerge Merge the pull request once unit tests and other checks pass. and removed api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 28, 2024
@@ -421,6 +421,11 @@ def to_gbq(
class GeminiTextGenerator(base.BaseEstimator):
"""Gemini text generator LLM model.

Note: This product or feature is subject to the "Pre-GA Offerings Terms" in the General Service Terms section of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should follow a docstring format like this for note:

.. note::
    This product or feature is subject to the "Pre-GA Offerings Terms" in the General Service Terms section of the

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@GarrettWu GarrettWu requested a review from ashleyxuu March 29, 2024 00:21
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 769868b into main Mar 29, 2024
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the garrettwu-docs branch March 29, 2024 04:12
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 29, 2024
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants