Skip to content

fix: rename Embedding output columns to be back-compatible #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: rename Embedding output columns to be back-compatible #561

merged 1 commit into from
Apr 2, 2024

Conversation

GarrettWu
Copy link
Contributor

…backward compatible

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested review from tswast and ashleyxuu April 2, 2024 00:20
@GarrettWu GarrettWu requested review from a team as code owners April 2, 2024 00:20
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 2, 2024
ashleyxuu
ashleyxuu approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@GarrettWu GarrettWu merged commit 4995c00 into main Apr 2, 2024
16 checks passed
@GarrettWu GarrettWu deleted the garrettwu-embed branch April 2, 2024 03:47
@release-please release-please bot mentioned this pull request Apr 2, 2024
Merged
@tswast
Copy link
Collaborator

tswast commented Apr 2, 2024

Thank you for the quick fix!

Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
@GarrettWu @Genesis929
fix: rename PaLM2TextEmbeddingGenerator.predict output columns to be …
76afa76 
…backward compatible (#561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyxuu ashleyxuu ashleyxuu approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GarrettWu @tswast @ashleyxuu