-
Notifications
You must be signed in to change notification settings - Fork 48
feat: allow functions decorated with @bpd.remote_function
to execute locally
#704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e2e failure I'm not sure what's going on with the |
Regarding the other failures, looks like the functions were failing to start due to:
I wonder if it's because we're pickling more than we used to because the function body is now intact? Will look a bit deeper. |
Looks like this only affected some specific tests that basically decorated the same function twice. Should be fixed by cc11de5 |
Remaining failures:
I don't think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_remote_function_via_session_vpc_invalid
Is this related to your change?
This is also failing in other PRs unrelated to this change. Filed internal issue 341772893 to investigate. |
BEGIN_COMMIT_OVERRIDE
feat: allow functions decorated with
bpd.remote_function()
to execute locally (#704)END_COMMIT_OVERRIDE
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
🦕