feat: support fit() in GeminiTextGenerator #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettWu
reviewed
Jun 6, 2024
tests/system/load/test_llm.py
Outdated
| model_name="gemini-pro", max_iterations=1 | ||
| ) | ||
|
|
||
| df = llm_fine_tune_df_default_index.dropna().sample(n=100) |
There was a problem hiding this comment.
don't need to dropna and sample after #760
| X, y = utils.convert_to_dataframe(X, y) | ||
|
|
||
| options = self._bqml_options | ||
| options["endpoint"] = "gemini-1.0-pro-002" |
There was a problem hiding this comment.
Spill out the model version to be used for tuning in docs.
There was a problem hiding this comment.
Our model name is "gemini-pro-1.0", but their endpoint is called "gemini-1.0-pro-002". Any ideas for how to spill out it?
There was a problem hiding this comment.
synced offline, no need to document the model version now: https://cloud.google.com/vertex-ai/generative-ai/docs/learn/model-versioning#auto-updated-models
| GeminiTextGenerator: Fitted estimator. | ||
| """ | ||
| if self._bqml_model.model_name.startswith("gemini-1.5"): | ||
| raise NotImplementedError("Fit is not supported for gemini-1.5 model.") |
There was a problem hiding this comment.
Also mention supported model types in docs.
GarrettWu
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal #343765747🦕