feat: add dataframe.insert #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettWu
reviewed
Jun 10, 2024
bigframes/dataframe.py
Outdated
| column_count = len(self.columns) | ||
| if loc > column_count: | ||
| raise IndexError( | ||
| f"index {loc} is out of bounds for axis 0 with size {column_count}" |
There was a problem hiding this comment.
axis 0 doesn't exist in this context
There was a problem hiding this comment.
Yes, but this is the message pandas used for insert for some reason. Maybe just mean the columns.
bigframes/dataframe.py
Outdated
|
|
||
| block = df._get_block() | ||
| value_columns = typing.cast(List, block.value_columns) | ||
| value_columns = ( |
There was a problem hiding this comment.
Just List.insert() can do the job.
GarrettWu
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕
Docs screenshot:
https://screenshot.googleplex.com/44Hv89QdsGxbKaS
https://screenshot.googleplex.com/8sdZyxEcCzxd2ac