Skip to content

fix: include internally required packages in remote_function hash #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Jun 18, 2024

We compute cloud function and BQ remote function id based on a hash computed from the udf code and external package requirements. But there are internal package requirements as well, which don't play a part in the hash computation. Because of this, if internal package version changes, it does not trigger redeployment of the cloud function. We are fixing that behavior in this change by including the internal package requirements in the hash computation.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 345549684 🦕

@shobsi shobsi requested review from a team as code owners June 18, 2024 23:01
@shobsi shobsi requested a review from GarrettWu June 18, 2024 23:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 18, 2024
@shobsi shobsi requested a review from tswast June 18, 2024 23:01
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jun 19, 2024
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shobsi shobsi merged commit 4b8fc15 into main Jun 25, 2024
23 checks passed
@shobsi shobsi deleted the shobs-rf-internal-packages-hash branch June 25, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants