Skip to content

fix: struct field non-nullable type issue. #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix: struct field non-nullable type issue. #914

merged 2 commits into from
Aug 22, 2024

Conversation

Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Aug 22, 2024

This issue is related to pypi.ipynb.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/361145903 🦕

@Genesis929 Genesis929 requested review from a team as code owners August 22, 2024 17:54
@Genesis929 Genesis929 requested a review from shobsi August 22, 2024 17:54
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 22, 2024
Copy link
Contributor

@shobsi shobsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's find a way to write a system test to showcase the value of this change yaqs/4269233226351902720 in a later PR

@Genesis929 Genesis929 merged commit 149d5ff into main Aug 22, 2024
23 checks passed
@Genesis929 Genesis929 deleted the nbfix-huanc branch August 22, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants