Skip to content

test: add code snippets for using bigframes.ml #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 1, 2023
Merged

test: add code snippets for using bigframes.ml #159

merged 12 commits into from
Nov 1, 2023

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested review from a team as code owners October 31, 2023 17:17
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 31, 2023
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Oct 31, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ashleyxuu ashleyxuu requested review from tswast and removed request for parthea and Genesis929 October 31, 2023 17:17
@ashleyxuu
Copy link
Contributor Author

The code snippets here are prepared for the content of "Use BigQuery DataFrames" page.
Content: https://docs.google.com/document/d/1N5mbfoTh63SwTRFkqs-j9m_2WIykDKHPKAECvKScDSg/edit#heading=h.nq1i22bqeo4y

tswast
tswast reviewed Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern with merging this PR is that running some of these samples may take a long time. It might be best to create a separate folder for these and exclude them from our presubmit samples tests and move the ML samples tests to the e2e job.

ashleyxuu and others added 4 commits November 1, 2023 19:14
@ashleyxuu @shobsi
test: add code snippets for loading data from BigQuery Job (#154)
aa442ce 
* test: add code snippets for loading data from BigQuery Job

* fix: address the comments

* fix: fix the broken test

* use BigQuery Client library to get the job_id

* feat: Implement operator `@` for `DataFrame.dot` (#139)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes b/297502513 🦕

* fix: fix the comments

---------

Co-authored-by: Shobhit Singh <[email protected]>
@orrbradford @ashleyxuu
feat: add bigframes.options.compute.maximum_bytes_billed option that …
14bf68d 
…sets maximum bytes billed on query jobs (#133)

-implement context manager for global options
-maximum_bytes_billed only applies to query jobs. This limitation will be set per query. Operations that trigger multiple jobs may result in total usage beyond this setting
@tswast @ashleyxuu
docs: fix indentation on read_gbq_function code sample (#163)
9a42f03 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@ashleyxuu
move ml samples to e2e, make the tests standalone
fdeb9f2
@ashleyxuu ashleyxuu requested a review from a team as a code owner November 1, 2023 19:14
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 1, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Nov 1, 2023
milkshakeiii and others added 2 commits November 1, 2023 21:15
@milkshakeiii @ashleyxuu
feat: add pd.get_dummies (#149)
32e03cc 
* feat: add pd.get_dummies

* remove unneeded prefix case

* param/documentation fixes

* be stricter about types in test

* be stricter about types in series test

* remove unneeded comment

* adjust for type difference in pandas 1

* add example code (tested)

* fix None columns and add test cases

* variable names and _get_unique_values per-column

* account for pandas 1 behavior difference

* remove already_seen set

* avoid unnecessary join/projection

* fix column ordering edge case

* adjust for picky examples checker

* example tweak

* make part of the example comments

* use ellipsis in doctest comment

* add <BLANKLINES> to doctest string

* extract parameter standardization

* extract submethods

---------

Co-authored-by: Henry J Solberg <[email protected]>
@ashleyxuu
fix: fix the failed test
a005bd1
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 1, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Nov 1, 2023
tswast
tswast approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These are great.

@ashleyxuu ashleyxuu merged commit 3d7a0d6 into main Nov 1, 2023
@ashleyxuu ashleyxuu deleted the add-code-snippets-use-ml branch November 1, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashleyxuu @tswast @orrbradford @milkshakeiii