deps: include pyarrow as a dependency
#529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test with a minimum version of pyarrow to confirm compatibility.
milkshakeiii
approved these changes
Mar 27, 2024
testing/constraints-3.9.txt
Outdated
| @@ -12,6 +12,7 @@ google-cloud-resource-manager==1.10.3 | |||
| google-cloud-storage==2.0.0 | |||
| ibis-framework==8.0.0 | |||
| pandas==1.5.0 | |||
| pyarrow==3.0.0 | |||
There was a problem hiding this comment.
can this be higher? looks like
E AttributeError: type object 'pyarrow.lib.RecordBatch' has no attribute 'from_pydict'
is due to 3.0.0 being too old
There was a problem hiding this comment.
Work-in-progress. I need to determine what our minimum version actually is. Will update this PR with a bit of a binary search to determine.
Genesis929
pushed a commit
that referenced
this pull request
Apr 9, 2024
* deps: include `pyarrow` as a dependency Test with a minimum version of pyarrow to confirm compatibility. * fix unit test * fix unit tests * try pyarrow 11 * try pyarrow 8 * skip failing astype test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with a minimum version of pyarrow to confirm compatibility.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
🦕