Skip to content

chore: run doctest and notebook tests in bigframes-testing project #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 26, 2024
Merged

chore: run doctest and notebook tests in bigframes-testing project #976

merged 13 commits into from
Sep 26, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Sep 11, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shobsi shobsi requested review from a team as code owners September 11, 2024 19:23
@shobsi shobsi requested a review from chelsea-lin September 11, 2024 19:23
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 11, 2024
@shobsi shobsi marked this pull request as draft September 13, 2024 19:14
@shobsi shobsi marked this pull request as ready for review September 17, 2024 18:52
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 24, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@shobsi shobsi changed the title chore: target bigframes-testing project for doctest and notebook tests chore: run doctest and notebook tests in bigframes-testing project Sep 26, 2024
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Sep 26, 2024
@chelsea-lin chelsea-lin merged commit 1604139 into main Sep 26, 2024
23 checks passed
@chelsea-lin chelsea-lin deleted the shobs-setup-bigframes-testing branch September 26, 2024 20:08
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@TrevorBergeron TrevorBergeron

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobsi @chelsea-lin @TrevorBergeron