Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

docs(samples): Adding Windows server samples #274

Merged
merged 10 commits into from
May 5, 2022
Merged

Conversation

m-strzelczyk
Copy link
Contributor

Providing samples needed on the Creating and managing Windows Server instances page.

Test is provided for route samples, as other samples that involve firewall or instance creation are already tested

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: compute Issues related to the googleapis/python-compute API. labels Apr 26, 2022
@snippet-bot
Copy link

snippet-bot bot commented Apr 26, 2022

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@m-strzelczyk m-strzelczyk changed the title Samples windows2 docs(samples): Adding Windows server samples Apr 26, 2022
@m-strzelczyk m-strzelczyk marked this pull request as ready for review April 26, 2022 14:58
@m-strzelczyk m-strzelczyk requested review from a team as code owners April 26, 2022 14:58
@m-strzelczyk m-strzelczyk requested a review from parthea April 26, 2022 14:58
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 27, 2022
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations, otherwise LGTM

@m-strzelczyk m-strzelczyk merged commit 06291b5 into main May 5, 2022
@m-strzelczyk m-strzelczyk deleted the samples-windows2 branch May 5, 2022 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants