Skip to content

New release to allow google-cloud-logging 3.0? #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snarfed opened this issue Feb 9, 2022 · 4 comments · Fixed by #244
Closed

New release to allow google-cloud-logging 3.0? #227

snarfed opened this issue Feb 9, 2022 · 4 comments · Fixed by #244
Assignees
Labels
api: clouderrorreporting Issues related to the googleapis/python-error-reporting API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@snarfed
Copy link

snarfed commented Feb 9, 2022

Hi all! First off, thank you for maintaining this library. We all appreciate it!

google-cloud-logging 3.0 is out, but google-cloud-error-reporting restricts its dependencies pretty narrowly, so 1.4.1 doesn't support 3.0. Looks like that constraint is already updated in #224 though, any chance you could cut a release with it?

More broadly, #224 still restricts to google-cloud-logging>=1.14.0, <3.0.1, so we'll have this exact same problem with the next google-cloud-logging release. Ideally libraries should be more permissive in their dependency constraints to avoid this problem. Consider relaxing it to <4.0, or something similar?

@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/python-error-reporting API. label Feb 9, 2022
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 10, 2022
@johan-torres-data
Copy link

Hi everyone, thanks a lot for your effort in supporting issues related to error_reporting.
Working with python 3.8.5 and the same problem here with the dependencies:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. google-cloud-error-reporting 1.4.1 requires google-cloud-logging<3.0.0dev,>=1.14.0, but you have google-cloud-logging 3.0.0 which is incompatible.

@daniel-sanche
Copy link
Contributor

Thanks for reporting this, I started the process to release v1.5.0, which should fix this issue

@snarfed
Copy link
Author

snarfed commented Feb 18, 2022

Thank you @daniel-sanche!

Any thoughts on this part though?

More broadly, #224 still restricts to google-cloud-logging>=1.14.0, <3.0.1, so we'll have this exact same problem with the next google-cloud-logging release. Ideally libraries should be more permissive in their dependency constraints to avoid this problem. Consider relaxing it to <4.0, or something similar?

The same problem happened a while ago in #92, and it will happen again as soon as google-cloud-logging cuts their next release, as described above. Any chance you could configure your renovate bot to relax the upper bound to at least the next major version (assuming semver), eg <4.0?

@snarfed
Copy link
Author

snarfed commented Mar 7, 2022

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouderrorreporting Issues related to the googleapis/python-error-reporting API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants