You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently each subchannel implicitly refreshes the name resolution when its connection is broken. That is, this feature is built into subchannel's internal implementation. Although it eliminates the burden of having LoadBalancer implementations refresh the name resolution when connections to backends are broken, this is gives LoadBalancer no chance to disable or override this refresh.
We'd want to let LoadBalancer manage refreshes explicitly. The API has already been there for a long time: LoadBalancer.Helper.refreshNameResolution(). During the transition, SubchannelImpl will check if Helper.refreshNameResolution() is called when its connection is broken. If not, it will still refresh the resolution and log a warning. This will be removed in the future and LoadBalancers are completely responsible for triggering the refresh.
As a side effect of this check, LoadBalancers that intentionally do not want the refresh (e.g., xDS) will cause the warning. So we are adding a temporary LoadBalancer.Helper API, ignoreRefreshNameResolutionCheck() to help the transition. It's been marked as deprecated, xDS should be the only LoadBalancer implementation that uses it.
The text was updated successfully, but these errors were encountered:
Currently each subchannel implicitly refreshes the name resolution when its connection is broken. That is, this feature is built into subchannel's internal implementation. Although it eliminates the burden of having LoadBalancer implementations refresh the name resolution when connections to backends are broken, this is gives LoadBalancer no chance to disable or override this refresh.
We'd want to let LoadBalancer manage refreshes explicitly. The API has already been there for a long time:
LoadBalancer.Helper.refreshNameResolution()
. During the transition, SubchannelImpl will check ifHelper.refreshNameResolution()
is called when its connection is broken. If not, it will still refresh the resolution and log a warning. This will be removed in the future and LoadBalancers are completely responsible for triggering the refresh.As a side effect of this check, LoadBalancers that intentionally do not want the refresh (e.g., xDS) will cause the warning. So we are adding a temporary LoadBalancer.Helper API,
ignoreRefreshNameResolutionCheck()
to help the transition. It's been marked as deprecated, xDS should be the only LoadBalancer implementation that uses it.The text was updated successfully, but these errors were encountered: