Add bifunctors instances for Servant.API.Alt #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These mirror the corresponding instances for (,)
alpmestan
approved these changes
Sep 5, 2018
phadej
suggested changes
Sep 5, 2018
servant/servant.cabal
Outdated
| @@ -84,6 +84,7 @@ library | |||
| -- Here can be exceptions if we really need features from the newer versions. | |||
| build-depends: | |||
| base-compat >= 0.10.4 && < 0.11 | |||
| , bifunctors >= 5.4 && < 5.6 | |||
There was a problem hiding this comment.
>= 5.5.3
or is there a reason to have lose lower bound? (Stackage nightly has 5.5.3...)
There was a problem hiding this comment.
Ah! I misread the comment, I understood it to mean make sure we include the latest Stackage nightly but it's OK to be looser. I can change that!
There was a problem hiding this comment.
My bad. I'll improve the wording.
phadej
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mirror the corresponding instances for (,)