Skip to content

Add MonadMask instance for Handler #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2018
Merged

Add MonadMask instance for Handler #1068

merged 1 commit into from
Nov 6, 2018

Conversation

cocreature
Copy link
Contributor

exceptions-0.10 has introduced a working MonadMask instancesfor ExceptT so we can now also provide this for Handler. servant-server already has a lower bound of >= 0.10 on exceptions, so this doesn’t impose any additional restrictions.

alpmestan
alpmestan approved these changes Nov 4, 2018
View reviewed changes
Copy link
Contributor

@alpmestan alpmestan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cocreature :-)

@alpmestan alpmestan merged commit 56d95ae into haskell-servant:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpmestan alpmestan alpmestan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @alpmestan