Update CookieJar with intermediate request/responses using Network.HTTP.Client.HistoriedResponse. #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpmestan
approved these changes
Jan 11, 2019
|
LGTM, but it'd be great to add a test that exercises the "with cookie jar" code path to make sure 1/ it works as expected and 2/ it doesn't break in the future. Do you feel like adding this? Thanks! |
|
I should be able to add a test case. Let me take a look. |
|
Added a test case. |
alpmestan
approved these changes
Jan 25, 2019
|
@phadej Any objection to merging this? |
phadej
reviewed
Jan 26, 2019
phadej
reviewed
Jan 27, 2019
alpmestan
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any cookies that are set prior to a redirect won't be available in the
CookieJarinClientEnv. UsingHistoriedResponseallows the updating of theCookieJarwith all the requests/responses.