Allow http-api-data 0.4.1 #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
suggested changes
May 28, 2019
servant/servant.cabal
Outdated
| @@ -98,7 +98,7 @@ library | |||
| -- We depend (heavily) on the API of these packages: | |||
| -- i.e. re-export, or allow using without direct dependency | |||
| build-depends: | |||
| http-api-data >= 0.4 && < 0.4.1 | |||
| http-api-data >= 0.4 && < 0.4.2 | |||
There was a problem hiding this comment.
We depend on tight range, as the API is re-exported.
Please bump lower bounds to >=0.4.1
2e340b0 to
8ea584f
Compare
|
I fixed the Sorry for inconvenience, I didn't notice the failure at first. |
Builds fine and all tests pass here.
8ea584f to
91520e2
Compare
|
Sure, rebased :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds fine and all tests pass here.