-
-
Notifications
You must be signed in to change notification settings - Fork 416
Delayed cleanup ioref tests #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delayed cleanup ioref tests #674
Conversation
…n use the result of bodyD to perform some IO clean up operation
… allowing early clean up registration
I'm ok with merging this, and then rewriting newtype DelayedIO a = DelayedIO { runDelayedIO' :: ReaderT Request (ResourceT IO) (RouteResult a) }
-- or even
newtype DelayedIO a = DelayedIO { runDelayedIO' :: ReaderT Request (ResourceT (RouteResultT IO)) a } opinions on this, @alpmestan, @jkarni? for the reference: |
c31e783
to
85f5000
Compare
There's some build failure to address (https://travis-ci.org/haskell-servant/servant/jobs/192826872#L393) -- for ghc 7.8. Other than that, LGTM. We can merge once it's fixed. |
Why not just use |
d2614d0
to
87707a3
Compare
87707a3
to
60ee1ab
Compare
@jkarni I'll make a refactor PR today. |
Rebase of #622, with tests changed to use
IORef