Suppress warnings in autogenerated signatures. #5678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue haskell#5677 demonstrates one way for warnings to be produced by dummy signatures. Autogenerated code really ought to never be generating warnings, under any sets of flags provided by the user; this patch uses the big hammer of entirely disabling warnings for the generated signatures. Fixes haskell#5677.
|
Should be straightforward enough to merge to 2.4, too, so I'll milestone it. |
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "b093ebebdc0068ded64fd58b2b804ea6b56c0b1e", "tag":"linux-7.10.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "b093ebebdc0068ded64fd58b2b804ea6b56c0b1e", "tag":"linux-8.0.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "b093ebebdc0068ded64fd58b2b804ea6b56c0b1e", "tag":"linux-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "b093ebebdc0068ded64fd58b2b804ea6b56c0b1e", "tag":"linux-7.6.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"linux-8.0.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"linux-7.10.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"linux-7.6.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"linux-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"linux-8.2.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"linux-8.6.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"linux-8.4.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"linux-8.4.4-fdebug-expensive-assertions" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"osx-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"osx-7.10.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 9, 2018
"url":"pull/5678", "account":"haskell", "repo":"cabal", "commit": "21240bbb919983a8e0bca83730584a91c6cad904", "tag":"osx-8.0.2" }
|
Merged, thanks! |
23Skidoo
added a commit
that referenced
this pull request
Nov 9, 2018
Suppress warnings in autogenerated signatures. (cherry picked from commit f2c3025)
|
Also cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5677 demonstrates one way for warnings to be produced by dummy
signatures. Autogenerated code really ought to never be generating
warnings, under any sets of flags provided by the user; this patch
uses the big hammer of entirely disabling warnings for the generated
signatures.
Fixes #5677.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!