Remove Environment blend mode from spec and explainer #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Associated "add" commit will exist in the webxr-ar-module repository
Manishearth
approved these changes
Aug 13, 2019
toji
reviewed
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on today's call, we have agreed to move the environment blend mode into the ar module. This PR removes it from the core WebXR spec. An associated PR will be posted to add the mode into the AR module. This PR will remain in draft mode until the other PR has been posted.
Based on today's call, we have agreed to move the environment blend mode from the WebXR Device API to the WebXR Augmented Reality Module. This PR removes it from the core webxr repository. The associated PR to add it to the webxr-ar-module repo is immersive-web/webxr-ar-module#2