New API org.jacoco.core.tools #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Java Code Coverage Tools » jacoco #155 SUCCESS |
| * <code>reset==false</code>, <code>retryCount==0</code> and | ||
| * <code>retryDelay=1000</code>. | ||
| */ | ||
| public ExecDumpClient() { |
There was a problem hiding this comment.
I would like to see another constructor with all arguments given to make them final instead of providing setters. The only advantage of using setters here is that you may not mix arguments unintentionally.
There was a problem hiding this comment.
While I'm also a fan of immutable objects I prefer this solution here for the following reasons:
- Avoid too many parameters for an constructor
- provide out-of-the box default behavior
- extensible API for additional attributes in future.
|
Java Code Coverage Tools » jacoco #156 SUCCESS |
|
I really like the |
|
@mfriedenhagen Thanks for reviewing this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new API package org.jacoco.core.tools for high level tools shared by different JaCoCo integrations.