Skip to content

Provide context information when zip reading throws IllegalArgumentException #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 14, 2025
Merged

Provide context information when zip reading throws IllegalArgumentException #1833

merged 9 commits into from
Jan 14, 2025

Conversation

Godin
Copy link
Member

@Godin Godin commented Jan 10, 2025

Fixes #1832

@Godin Godin self-assigned this Jan 10, 2025
@Godin Godin force-pushed the analyzeZip_nextEntry_IllegalArgumentException branch 6 times, most recently from f255f11 to def4b58 Compare January 10, 2025 15:14
@Godin Godin force-pushed the analyzeZip_nextEntry_IllegalArgumentException branch from def4b58 to 14bdaf0 Compare January 10, 2025 15:35
@Godin Godin added this to the 0.8.13 milestone Jan 10, 2025
@Godin Godin changed the title Analyzer.nextEntry should catch IllegalArgumentException Provide context information when zip reading throws IllegalArgumentException Jan 10, 2025
@Godin Godin marked this pull request as ready for review January 10, 2025 19:41
@Godin Godin requested review from marchof and leveretka January 10, 2025 19:41
@Godin Godin enabled auto-merge (squash) January 10, 2025 19:41
marchof
marchof requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@marchof marchof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the same situation in Instrumenter.nextEntry(). This should also be fixed.

@Godin Godin disabled auto-merge January 14, 2025 14:08
@Godin Godin enabled auto-merge (squash) January 14, 2025 14:08
@Godin Godin requested a review from marchof January 14, 2025 15:27
@Godin Godin merged commit 4e796ea into jacoco:master Jan 14, 2025
34 checks passed
@Godin Godin deleted the analyzeZip_nextEntry_IllegalArgumentException branch January 14, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchof marchof marchof approved these changes

@leveretka leveretka Awaiting requested review from leveretka

Assignees

@Godin Godin

Labels
component: core
Projects
None yet
Milestone
0.8.13
Development

Successfully merging this pull request may close these issues.

Malformed Zip-crash should provide more detailed error information
2 participants
@Godin @marchof