Remove signatures from instrumented JAR files

[marchof]

The instrument Ant task should remove signatures from JAR files as instrumentation breaks these signatures.

This behavior should be configurable with a new attribute removesignatures which defaults to true.

[marchof]

@Godin @mfriedenhagen Should this behaviour also be configurable for the instrument Maven goal? From my understanding the Maven goal would be used on class files only, right?

[mfriedenhagen]

I will take a look this evening.
On Feb 22, 2014 10:32 AM, "Marc R. Hoffmann" [email protected]
wrote:

@Godin https://github.com/Godin @mfriedenhagenhttps://github.com/mfriedenhagenShould this behaviour also be configurable for the instrument Maven goal?
From my understanding the Maven goal would be used on class files only,
right?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/186#issuecomment-35798720
.

[buildhive]

Java Code Coverage Tools » jacoco #245 SUCCESS
This pull request looks good
(what's this?)

[marchof]

@mfriedenhagen Thx! Please also feel free to add review comments.

[mfriedenhagen]

@marchof: jacoco:instrument will only look into target/classes, so when you only use class files generated in your current Maven reactor using a full run ala mvn clean verify, this should not be a problem as Maven will use class files from target/classes instead of installed JARs.
However, when you use options like mvn --projects module_name --also-make clean verify, Maven might pick up installed JARs instead of using target/classes. And when you do wierd stuff like unpacking dependencies with the maven-dependency-plugin and add these classes as well as sources with the buildhelper-maven-plugin, there might be a problem (see https://github.com/mfriedenhagen/pastebin/tree/jacoco-with-sources-from-dependent-jars for an example).

All in all I do not think we have to adapt anything for Maven, people doing weird stuff may kust exclude META-INF/* from unpacking.

I compiled your PR successfully, so I will merge it.

[marchof]

@mfriedenhagen Ok, thanks for clarification!