having a single Buffer in LoggerSet for locking #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ruicc Are you OK with this PR? |
|
I will check behaviours.. |
ruicc
approved these changes
Sep 16, 2021
| pushLog :: IORef FD -> Logger -> LogStr -> IO () | ||
| pushLog fdref logger@(Logger size mbuf ref) nlogmsg@(LogStr nlen nbuilder) | ||
| pushLog :: IORef FD -> BufSize -> MVar Buffer -> Logger -> LogStr -> IO () | ||
| pushLog fdref size mbuf logger@(Logger ref) nlogmsg@(LogStr nlen nbuilder) |
There was a problem hiding this comment.
Writing is protected by the same MVar when message size is longer than buffer size. OK.
|
Merged. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 11, 2022
3.1.1 * More time-ordered logging functions [#199](kazu-yamamoto/logger#199 3.1.0 * Having a single Buffer in LoggerSet for locking [#197](kazu-yamamoto/logger#197. This would have performance penalty. So, the major version bumps up. If you see performance regression, please register an issue on github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #196