Added nostrip to CONFIG to avoid illegal binary strips on WSL

[sgourdas]

Fixes #1059

Added the nostrip flag to CONFIG in the kiwix-desktop.pro in case of WSL

[kelson42]

I don't think we want to just remove it everywhere. The best solution would be to do this only for WSL. The second best would be to do that via qmake/makefile option and document the case properly.

[kelson42]

@sgourdas Have you found a way to detect WSL properly?

[sgourdas]

@kelson42 Based on this it seems like checking for the existence of /proc/sys/fs/binfmt_misc/WSLInterop is the most reliable method, IMO as well, to check for WSL. I added a conditional check for this in the .pro file.

If this is fine for you also, I can squash the commits so we can merge.

[kelson42]

@sgourdas Thx, I will give a try and verify if it works fine for Linux at least.

[kelson42]

@sgourdas This piece of code deserves a small code comment explaining the situation/solution

[sgourdas]

@kelson42 is this fine?

[mgautierfr]

This comment is not so useful. We already see that we are checking existence of /proc/sys/fs/binfmt_misc/WSLInterop in the code. With a small variable renaming we can easily give the hint about what we are checking.

If we add comment, it should be why we do this, not what or how we are doing it.

I suggest:

# install script fails to detect if file is a binary or not on wsl and then try to strip all
# installed files, which obviously not work for all files. So don't strip on WSL.
ARE_WE_IN_WSL = $$system(test -f /proc/sys/fs/binfmt_misc/WSLInterop && echo true || echo false)
equals(ARE_WE_IN_WSL, "true"): CONFIG += nostrip

[sgourdas]

Totally agree.

Should we make it smaller, with something like:

# Avoid stripping incompatible files, due to false identification as executables, on WSL
DETECT_WSL = $$system(test -f /proc/sys/fs/binfmt_misc/WSLInterop && echo true || echo false)
equals(DETECT_WSL , "true"): CONFIG += nostrip

[kelson42]

LGTM, please do and squash everything in one commit so we can merge.

[kelson42]

LGTM