Added ContextMenu Button for Previewing Online Books #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eee8fb2 to
346fb55
Compare
veloman-yunkan
requested changes
May 15, 2024
346fb55 to
73ee0b6
Compare
veloman-yunkan
requested changes
May 15, 2024
73ee0b6 to
2d22286
Compare
veloman-yunkan
requested changes
May 17, 2024
There was a problem hiding this comment.
Good.
Please split the PR into two commits:
- Extracting a piece of inline code into a new function
ContentManager::getRemoteLibraryUrl()so that you can take advantage of it while implementing the desired functionality. - Implementing the functionality itself.
As a general rule - we care not only about the final code but also about the path of arriving at it. As a series of small commits the change is easier to comprehend. Also it allows to distinguish changes that affect user-observable behaviour from refactoring changes where only the organization of the code is concerned.
Refactored existing file static function makeHttpUrl to a member function that retrieves the remote library url from the request manager. Will be used for implementing the preview functionality.
Added action to open preview of an online book in native web browser. The option is available for books with states Online, Downloading, and Paused.
2d22286 to
0c86518
Compare
veloman-yunkan
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1100
Changes: