Filter out service worker based content from the online library #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgautierfr @veloman-yunkan Can I merge this? |
juuz0
requested changes
Sep 25, 2022
There was a problem hiding this comment.
Unfortunately, doesn't work for me, file still shows up in my library.
This is the file
https://drive.google.com/file/d/1e_sSHD86NI6u7A-LetWW1C6Ap16w1p2d/view?usp=sharing
|
Yes, this is for the online library only. To me this is good enough. If someone wants really to load one, and use it with HTTP daemon, then it should be possible. This is why I have talked of OPDS stream in the ticket, but thiscwad not super specific indeed. |
veloman-yunkan
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #780 and superseeds #870