fix(sdk): fixes type issues for ParallelFor. Fixes #9366 #10436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor-mccarthy
requested changes
Jan 29, 2024
sdk/python/test_data/pipelines/pipeline_with_parallelfor_parallelism.py
Outdated
Show resolved
Hide resolved
6a3834a to
cbdecbe
Compare
2269a27 to
b5fc32e
Compare
connor-mccarthy
requested changes
Feb 5, 2024
sdk/python/test_data/pipelines/pipeline_with_parallelfor_parallelism.py
Outdated
Show resolved
Hide resolved
sdk/python/test_data/pipelines/pipeline_with_parallelfor_parallelism.py
Outdated
Show resolved
Hide resolved
connor-mccarthy
requested changes
Feb 6, 2024
|
/retest |
1 similar comment
|
/retest |
connor-mccarthy
requested changes
Feb 7, 2024
sdk/python/test_data/pipelines/pipeline_with_parallelfor_parallelism.py
Outdated
Show resolved
Hide resolved
|
/retest |
connor-mccarthy
requested changes
Feb 7, 2024
connor-mccarthy
approved these changes
Feb 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rickyxie0929: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
roytman
pushed a commit
to roytman/pipelines
that referenced
this pull request
Feb 14, 2024
…eflow#10436) * fix type issues * fix type issue * fix format * fix failed test * fix format * delete comments * resolve comments * resolve comments * resolve format * resolve import * move unnecessary file * resolve compiler_test failures * resolve comments * remove unnecessary imports * fix format sort * fix nits * add new compiled yaml file * solve merge conflicts * solve conflicts * format * sort * resolve comments * resolve comments Signed-off-by: Alexey Roytman <[email protected]>
stijntratsaertit
pushed a commit
to stijntratsaertit/kfp
that referenced
this pull request
Feb 16, 2024
…eflow#10436) * fix type issues * fix type issue * fix format * fix failed test * fix format * delete comments * resolve comments * resolve comments * resolve format * resolve import * move unnecessary file * resolve compiler_test failures * resolve comments * remove unnecessary imports * fix format sort * fix nits * add new compiled yaml file * solve merge conflicts * solve conflicts * format * sort * resolve comments * resolve comments
petethegreat
pushed a commit
to petethegreat/pipelines
that referenced
this pull request
Mar 27, 2024
…eflow#10436) * fix type issues * fix type issue * fix format * fix failed test * fix format * delete comments * resolve comments * resolve comments * resolve format * resolve import * move unnecessary file * resolve compiler_test failures * resolve comments * remove unnecessary imports * fix format sort * fix nits * add new compiled yaml file * solve merge conflicts * solve conflicts * format * sort * resolve comments * resolve comments
petethegreat
pushed a commit
to petethegreat/pipelines
that referenced
this pull request
Mar 29, 2024
…eflow#10436) * fix type issues * fix type issue * fix format * fix failed test * fix format * delete comments * resolve comments * resolve comments * resolve format * resolve import * move unnecessary file * resolve compiler_test failures * resolve comments * remove unnecessary imports * fix format sort * fix nits * add new compiled yaml file * solve merge conflicts * solve conflicts * format * sort * resolve comments * resolve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Fix the compile errors when using dictionary type in ParallelFor.
Checklist: