Skip to content

fix(sdk): require google-api-core>=1.31.5, >=2.3.2 #7377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2022
Merged

fix(sdk): require google-api-core>=1.31.5, >=2.3.2 #7377

merged 2 commits into from
Mar 4, 2022

Conversation

chensun
Copy link
Member

@chensun chensun commented Mar 4, 2022

Description of your changes:
Require google-api-core>=1.31.5, >=2.3.2, to avoid the bug exists before these versions. See the python-api-core release notes for details.

KFP SDK does not have a direct dependency on google-api-core, but gets it via google-cloud-storage, which got the same fix (googleapis/python-storage@e9aab38) but not released yet. Until we can depend on a newer version of google-cloud-storage, we need to temporarily pin google-api-core versions from our end.

Checklist:

@chensun
Copy link
Member Author

chensun commented Mar 4, 2022

/cc @busunkim96

@google-oss-prow
Copy link

@chensun: GitHub didn't allow me to request PR reviews from the following users: busunkim96.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @busunkim96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

connor-mccarthy
connor-mccarthy approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that 2.6.0 is being installed on fresh kfp install:

google-cloud-storage==1.42.3
  - google-api-core [required: >=1.29.0,<3.0dev, installed: 2.6.0]

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 4, 2022
@google-oss-prow google-oss-prow bot merged commit 7f67130 into kubeflow:master Mar 4, 2022
@chensun chensun deleted the google-api-core-1-31-5 branch March 4, 2022 21:01
chensun added a commit that referenced this pull request Mar 7, 2022
@chensun
fix(sdk): require google-api-core>=1.31.5, >=2.3.2 (#7377)
dbfbe67 
* require google-api-core>=1.31.5, >=2.3.2

* add release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connor-mccarthy connor-mccarthy connor-mccarthy approved these changes

@ji-yaqi ji-yaqi Awaiting requested review from ji-yaqi

Assignees

@ji-yaqi ji-yaqi

@connor-mccarthy connor-mccarthy

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chensun @connor-mccarthy @ji-yaqi