Skip to content

chore(deps): Bump google-cloud-storage to 2.2.1 #7493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Mar 31, 2022

Description of your changes:

Fix the pip conflicts warning if the user also installed latest google-cloud-storage

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. 
This behaviour is the source of the following dependency conflicts.
kfp 1.8.11 requires google-cloud-storage<2,>=1.20.0, but you have google-cloud-storage 2.2.1 which is incompatible.

According to the change log https://github.com/googleapis/python-storage/blob/main/CHANGELOG.md#200-2022-01-12

The only breaking change is Remove Python 2 Support, which should be fine for kfp

Checklist:

@google-oss-prow
Copy link

Hi @haoxins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@connor-mccarthy
Copy link
Member

Thanks, @haoxins. I suspect that if this applies to either 1.8 (sdk/release-1.8 branch) and 2.0-alpha (master branch), it would also apply to the other.

It looks like you got this error message when pip installing locally to author a pipeline, not at pipeline execution time. Is that correct?

@ji-yaqi @chensun, given that the only breaking change is dropping support for Python 2, I think it should be okay to bump the version on this dependency. WDYT?

@connor-mccarthy
Copy link
Member

/ok-to-test

@haoxins
Copy link
Contributor Author

haoxins commented Mar 31, 2022

It looks like you got this error message when pip installing locally to author a pipeline, not at pipeline execution time. Is that correct?

Yes~

# https://github.com/googleapis/python-storage/blob/master/CHANGELOG.md#1200
google-cloud-storage>=1.20.0,<2
# https://github.com/googleapis/python-storage/blob/main/CHANGELOG.md#221-2022-03-15
google-cloud-storage>=2.2.1,<3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a release note for this change following the same format as

* Depends on `kfp-pipeline-spec>=0.1.14,<0.2.0` [\#7464](https://github.com/kubeflow/pipelines/pull/7464)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, we only use this library in v1 code (under deprecated folder in master branch). So we should be able to get rid of this dependency in the near future.
Meanwhile, this would be long-lived in sdk/release-1.8 branch. So can you please also send a PR to change it there? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a release note for this change following the same format as

* Depends on `kfp-pipeline-spec>=0.1.14,<0.2.0` [\#7464](https://github.com/kubeflow/pipelines/pull/7464)

added

@haoxins haoxins force-pushed the chore-upgrade-google-cloud-storage branch from c5e3207 to bad51d8 Compare April 1, 2022 03:10
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Apr 1, 2022
@chensun
Copy link
Member

chensun commented Apr 1, 2022

/lgtm
/approve

Thanks!

1 similar comment
@chensun
Copy link
Member

chensun commented Apr 1, 2022

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member

chensun commented Apr 1, 2022

/retest

2 similar comments
@chensun
Copy link
Member

chensun commented Apr 1, 2022

/retest

@connor-mccarthy
Copy link
Member

/retest

@chensun
Copy link
Member

chensun commented Apr 1, 2022

/test kubeflow-pipelines-samples-v2

@google-oss-prow google-oss-prow bot merged commit 48644ed into kubeflow:master Apr 1, 2022
@haoxins haoxins deleted the chore-upgrade-google-cloud-storage branch April 2, 2022 03:42
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants