-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore(deps): Bump google-cloud-storage to 2.2.1 #7493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump google-cloud-storage to 2.2.1 #7493
Conversation
Hi @haoxins. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks, @haoxins. I suspect that if this applies to either 1.8 ( It looks like you got this error message when pip installing locally to author a pipeline, not at pipeline execution time. Is that correct? @ji-yaqi @chensun, given that the only breaking change is dropping support for Python 2, I think it should be okay to bump the version on this dependency. WDYT? |
/ok-to-test |
Yes~ |
# https://github.com/googleapis/python-storage/blob/master/CHANGELOG.md#1200 | ||
google-cloud-storage>=1.20.0,<2 | ||
# https://github.com/googleapis/python-storage/blob/main/CHANGELOG.md#221-2022-03-15 | ||
google-cloud-storage>=2.2.1,<3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a release note for this change following the same format as
Line 21 in 2509f11
* Depends on `kfp-pipeline-spec>=0.1.14,<0.2.0` [\#7464](https://github.com/kubeflow/pipelines/pull/7464) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, we only use this library in v1 code (under deprecated
folder in master
branch). So we should be able to get rid of this dependency in the near future.
Meanwhile, this would be long-lived in sdk/release-1.8
branch. So can you please also send a PR to change it there? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a release note for this change following the same format as
Line 21 in 2509f11
* Depends on `kfp-pipeline-spec>=0.1.14,<0.2.0` [\#7464](https://github.com/kubeflow/pipelines/pull/7464)
added
c5e3207
to
bad51d8
Compare
/lgtm Thanks! |
1 similar comment
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
/test kubeflow-pipelines-samples-v2 |
Description of your changes:
Fix the pip conflicts warning if the user also installed latest
google-cloud-storage
According to the change log https://github.com/googleapis/python-storage/blob/main/CHANGELOG.md#200-2022-01-12
The only breaking change is Remove Python 2 Support, which should be fine for
kfp
Checklist: