Skip to content

fix(sdk): Fix PyPi typo in cli/component docstring #8361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

JOCSTAA
Copy link
Contributor

@JOCSTAA JOCSTAA commented Oct 13, 2022

Fix typo in docstring of cli/component : Pypi -> PyPI

@JOCSTAA JOCSTAA changed the title Fix PyPi typo in cli/component docs: Fix PyPi typo in cli/component docstring Oct 13, 2022
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @JOCSTAA. I think the title for this should be fix(sdk): as it is a fix affecting the SDK. This affects a docstring within the SDK, compared to docs which live under ./docs/.

@JOCSTAA JOCSTAA changed the title docs: Fix PyPi typo in cli/component docstring fix(sdk): Fix PyPi typo in cli/component docstring Oct 13, 2022
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks, @JOCSTAA!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7641401 into kubeflow:master Oct 13, 2022
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants