Defaulting of Custom Resources

[nikhita]

Feature Description

• One-line feature description (can be used as a release note): Support for defaulting of Custom Resources.
• Primary contact (assignee): @sttts
• Responsible SIGs: SIG API Machinery
• KEP:
  • Pruning - sig-api-machinery KEP: Pruning for CustomResources #709
    • 20180731-crd-pruning
  • Defaulting - sig-api-machinery KEP: Defaulting for Custom Resources #1006
    • 20190426-crd-defaulting
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • @deads2k
  • @liggitt
  • @mbohlool
  • @lavalamp
• Approver (likely from SIG/area to which feature belongs):
  • @deads2k
  • @lavalamp
• Feature target (which target equals to which milestone):
  • Alpha release target (v1.15)
  • Beta release target (v1.16)
  • Stable release target (v1.17)

[nikhita]

@justaugustus @idvoretskyi this is for 1.12.

/assign @sttts

original CRD feature: #95 (this is a sub-feature)
PR open: kubernetes/kubernetes#63604 (defaulting) and kubernetes/kubernetes#64558 (pruning)

/sig api-machinery
/kind feature
/stage alpha

[mbohlool]

Is there any design doc or discussion on this feature that I can read before diving into the code?

[nikhita]

Is there any design doc

It wasn't written originally but we plan to write a small design doc for this 👍

discussion on this feature

This was discussed in the sig api-machinery 31 January 2018 meeting: https://docs.google.com/document/d/1x9RNaaysyO0gXHIr1y50QFbiL1x8OWnk2v3XnrdkT5Y/edit#heading=h.l54g1ses43w1 (to those who want to read this, you might need to join the sig-api-machinery google group).

Defaulting was discussed in: kubernetes/kubernetes#55885, kubernetes/kubernetes#63604, go-openapi/validate#81

Pruning: kubernetes/kubernetes#59151, kubernetes/kubernetes#64558

[justaugustus]

@nikhita --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

• One-line feature description (can be used as a release note):
• Primary contact (assignee):
• Responsible SIGs:
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which feature belongs):
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y)
  • Beta release target (x.y)
  • Stable release target (x.y)

Set the following:

• Description
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

---

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

[justaugustus]

@sttts -- This has been added to the 1.12 Tracking sheet. Apologies for missing it before!

[zparnold]

Hey there! @nikhita I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[jimangel]

@sttts Bump for docs ☝️