add kubectl diff to cheatsheet #18481
Conversation
|
/assign @apelisse |
|
Thanks a lot @zhouya0 ! |
|
/assign @jimangel |
| @@ -195,6 +195,9 @@ kubectl get pods -o json | jq '.items[].spec.containers[].env[]?.valueFrom.secre | |||
|
|
|||
| # List Events sorted by timestamp | |||
| kubectl get events --sort-by=.metadata.creationTimestamp | |||
|
|
|||
| # Diff configurations with the current online configuration | |||
There was a problem hiding this comment.
I think there can be a clearer description here but I'm not sure how to word it. My concern is mainly around the word "online" which can be confusing, especially if your cluster is on-prem.
Maybe replace w/ cluster-state ?
There was a problem hiding this comment.
Let's be clear about what this does: it compares the current state of the cluster against the state that the cluster would be in if you had applied that configuration. I suspect with could almost use that sentence as-is.
# Compares the current state of the cluster against the state that the cluster would be in if the manifest was applied.
There was a problem hiding this comment.
Thanks a lot @apelisse. My native language is not english, to be honest i have to read multiple times with this sentence. But I aggree with the better explaination about the online cluster :)
728ee34 to
27de9e2
Compare
|
/lgtm |
|
@jimangel please review this, thanks! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, jimangel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add
kubectl diffto cheatsheet askubectl diffis already GA.Part of kubernetes/kubernetes#86525.