-
Notifications
You must be signed in to change notification settings - Fork 14.7k
[KEP-4639] Feature blog 1.33: Image volumes graduate to beta #49984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KEP-4639] Feature blog 1.33: Image volumes graduate to beta #49984
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
b0c71d5
to
369962d
Compare
369962d
to
15b0361
Compare
d6b5f8b
to
54790a1
Compare
54790a1
to
acc3c18
Compare
Ready for review. PTAL @kubernetes/sig-node-pr-reviews |
acc3c18
to
0e077cf
Compare
40c9454
to
aae73ce
Compare
/lgtm |
LGTM label has been added. Git tree hash: bd947399fd51cd1b3e0a3743ed25dd9611747cf0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reader following might get confused...
quay.io/crio/artifact:v1 ... subpath dir includes content file?
would be easier if the example had an actual directory and an actual file? or is the artifact:v1 actually filled with a dir named dir and a file named file :-) .. checking
regctl image get-file quay.io/crio/artifact:v1 dir/file
1
NVM.. though it is a bit confusing :-)
aae73ce
to
1bbdf14
Compare
volumes: | ||
- name: volume | ||
image: | ||
reference: quay.io/crio/artifact:v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to the v2
image similar to #50581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments added, but otherwise LGTM!
Signed-off-by: Sascha Grunert <[email protected]>
02f5096
to
0630c9d
Compare
Thank you! I applied the fixes as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 438ab5aa2809429c4ed3f0e9a46cb90fb9e8470c
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice piece @saschagrunert!
Just added a little suggestion about headings.
for the alpha feature which will be part of the v2.1.0 release and is working on | ||
beta support as part of [PR #11578](https://github.com/containerd/containerd/pull/11578). | ||
|
||
### What's new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### What's new | |
## What's new |
Maybe you missed it, I suggest to use consistent headings in the content.
If you then use a h2 heading it is not the best option to use an h3 first.
/remove-area localization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to merge as draft.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy, mikebrow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Blog post about the graduated feature.
Issue
Refers to kubernetes/enhancements#4639